Skip to content

[SDK] Feature: add flag for skipping default ecosystem info fetch #6052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SDK] Feature: add flag for skipping default ecosystem info fetch #6052

wants to merge 1 commit into from

Conversation

@alecananian
Copy link
Contributor

@alecananian alecananian commented Jan 24, 2025 •
edited by pr-codex bot
Loading

If an ecosystem has account abstraction settings turned on in the Thirdweb dashboard, there's currently no way through the SDK to allow users to log into their ecosystem wallets - they'll always be wrapped into their smart wallets for chains that use an account factory strategy (e.g., Arbitrum Sepolia chain ID 421614). We have a need to allow ecosystem wallet access for transferring assets that may have been mistakenly sent to that address.

PR-Codex overview

This PR introduces an optional flag for ecosystem wallet creation that allows users to skip fetching default ecosystem information. This enhances flexibility in wallet creation by providing developers with more control over the data retrieval process.

Detailed summary

  • Added skipEcosystemInfo flag in types.ts to skip fetching ecosystem info.
  • Updated ecosystem.ts to pass skipEcosystemInfo to wallet creation options.
  • Modified in-app-core.ts to conditionally fetch ecosystem info based on skipEcosystemInfo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@alecananian alecananian requested review from a team as code owners January 24, 2025 23:01
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: ced76d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 24, 2025

@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 24, 2025
@alecananian
Copy link
Contributor Author

alecananian commented Jan 27, 2025

Closing in favor of building out our own solution with ecosystemWallet.getAdminAccount()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alecananian